From 6e50d0952914d598fff4d151ca5a3ba09eb2bd22 Mon Sep 17 00:00:00 2001 From: Martin Lablans <6804500+lablans@users.noreply.github.com> Date: Fri, 20 Oct 2023 14:18:33 +0200 Subject: [PATCH] Apply suggestions from code review --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index b3f92a0..69f037f 100644 --- a/README.md +++ b/README.md @@ -354,22 +354,22 @@ Installation under WSL ought to work, but we have not tested this. ### Docker Daemon Proxy Configuration -Docker has a background daemon, responsible for downloading images and starting them. Sometimes, proxy configuration from your system won't carry over and it will fail to download images. In that case, you'll need to configure the proxy inside the system unit of docker by creating the file `/etc/systemd/system/docker.service.d/proxy.conf` with following content +Docker has a background daemon, responsible for downloading images and starting them. Sometimes, proxy configuration from your system won't carry over and it will fail to download images. In that case, you'll need to configure the proxy inside the system unit of docker by creating the file `/etc/systemd/system/docker.service.d/proxy.conf` with the following content: ``` ini [Service] Environment="HTTP_PROXY=http://proxy.example.com:3128" -Environment="HTTPS_PROXY=https://proxy.example.com:3129" -Environment="NO_PROXY=localhost,127.0.0.1,docker-registry.example.com,.corp" +Environment="HTTPS_PROXY=https://proxy.example.com:3128" +Environment="NO_PROXY=localhost,127.0.0.1,some-local-docker-registry.example.com,.corp" ``` -After saving the configuration file, you'll need to reload the system daemon for the changes to take effect +After saving the configuration file, you'll need to reload the system daemon for the changes to take effect: ``` shell sudo systemctl daemon-reload ``` -and restart the docker daemon +and restart the docker daemon: ``` shell sudo systemctl restart docker